Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: allow some types to be nil #76

Merged
merged 1 commit into from
Sep 7, 2023
Merged

refactor: allow some types to be nil #76

merged 1 commit into from
Sep 7, 2023

Conversation

MariaSolOs
Copy link
Contributor

When updating lsp-format a few days ago, I noticed that I was getting new diagnostics because of the new buffer parameter in on_attach, but the code handles the case in which this parameter is nil, so I'm updating the type accordingly.

While doing that I did the same change to other types, as well as move the method name to a higher scope to replace the raw string references everywhere.

Copy link
Owner

@lukas-reineke lukas-reineke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Once I'm done with the new indent blankline version, I'll clean these types up as well. And add LSP check to CI.

@lukas-reineke lukas-reineke merged commit 99fc647 into lukas-reineke:master Sep 7, 2023
@MariaSolOs MariaSolOs deleted the types branch September 7, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants