Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-resubscribe not working in cluster mode #110

Closed
klinquist opened this issue Jul 24, 2015 · 3 comments · Fixed by #112
Closed

Auto-resubscribe not working in cluster mode #110

klinquist opened this issue Jul 24, 2015 · 3 comments · Fixed by #112
Labels
bug

Comments

@klinquist
Copy link
Contributor

If I get time tomorrow, I'll take a look at the code :).
@luin luin added the bug label Jul 25, 2015
@luin luin mentioned this issue Jul 25, 2015
Merged
@luin
Copy link
Collaborator

luin commented Jul 25, 2015

Just submitted a pr to fix it.#112. I'm going to do more testing and write unit tests for it. Welcome to test it if you get time.

@klinquist
Copy link
Contributor Author

Just tested it on my side - seems to be working great!

Thank you!

@luin luin closed this as completed in #112 Jul 26, 2015
luin added a commit that referenced this issue Jul 26, 2015
@luin
Merge pull request #112 from luin/cluster/auto-resubscribe
05a0d12 
Auto-resubscribe channels in cluster mode. Close #110
@luin
Copy link
Collaborator

luin commented Jul 26, 2015

Fixed in 1.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Auto-resubscribe channels in cluster mode. redis/ioredis
2 participants
@luin @klinquist