Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a config option to disable sending of Version Negotiation packets #3216

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

marten-seemann
Copy link
Member

See libp2p/go-libp2p#1433 for context.

@codecov
Copy link

codecov bot commented Jun 27, 2021

Codecov Report

Merging #3216 (3a35902) into master (e9d12b7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3216   +/-   ##
=======================================
  Coverage   85.40%   85.41%           
=======================================
  Files         134      134           
  Lines        9825     9827    +2     
=======================================
+ Hits         8391     8393    +2     
  Misses       1060     1060           
  Partials      374      374           
Impacted Files Coverage Δ
config.go 100.00% <100.00%> (ø)
server.go 80.46% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9d12b7...3a35902. Read the comment docs.

@marten-seemann marten-seemann merged commit fa2e797 into master Jul 6, 2021
@marten-seemann marten-seemann deleted the disable-version-negotiation-option branch July 6, 2021 16:50
@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants