Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix HTTP request writing if the Request.Body reads data and returns EOF #2642

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

marten-seemann
Copy link
Member

Fixes #2641.

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #2642 into master will decrease coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2642      +/-   ##
==========================================
- Coverage   86.37%   86.36%   -0.01%     
==========================================
  Files         120      120              
  Lines        9743     9748       +5     
==========================================
+ Hits         8415     8418       +3     
- Misses        992      993       +1     
- Partials      336      337       +1     
Impacted Files Coverage Δ
http3/request_writer.go 65.13% <83.33%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eb2bb8...b8f36f3. Read the comment docs.

@marten-seemann marten-seemann merged commit 7c42d79 into master Jul 1, 2020
@marten-seemann marten-seemann deleted the fix-http-request-body-read-with-eof branch July 1, 2020 08:50
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http3.requestWriter doesn't write if Body.Read returns io.EOF with n > 0
2 participants