gracefully handle concurrent stream writes and cancellations #2624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the complete slice passed to Stream.Write() is sent out, and the stream is canceled concurrently (either by calling Stream.CancelWrite() or by receiving a STOP_SENDING frame), we don't need to return an error for the Write() call.
Codecov Report
@@ Coverage Diff @@
## master #2624 +/- ##
==========================================
- Coverage 86.21% 86.20% -0.01%
==========================================
Files 122 122
Lines 9775 9777 +2
==========================================
+ Hits 8427 8428 +1
- Misses 1004 1005 +1
Partials 344 344
Continue to review full report at Codecov.
|
lucas-clemente
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the complete slice passed to
Stream.Write()is sent out, and the stream is canceled concurrently (either by callingStream.CancelWrite()or by receiving a STOP_SENDING frame), we don't need to return an error for theWrite()call.This PR fixes #2593. What was happening in that test is the following: The client would send a GET request to the server. In some rare cases, the FIN is not bundled with the STREAM frame. The server then receives the HTTP request and writes the response. The HTTP handler returns before the FIN is received, and the server therefore calls
CancelRead()on the stream, which sends a STOP_SENDING frame. The client then receives and processes the STOP_SENDING before theWrite()call (that sent the request in the first place) had a chance to return.