Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-fetch v3 is out #115

Closed
etodanik opened this issue Sep 13, 2021 · 4 comments
Closed

node-fetch v3 is out #115

etodanik opened this issue Sep 13, 2021 · 4 comments

Comments

@etodanik
Copy link

Is it time to update?

@etodanik etodanik changed the title node-fetch v3 is out :) node-fetch v3 is out Sep 14, 2021
@p-j
Copy link

p-j commented Sep 24, 2021

Please don't

Fetch implementations that run on Node shouldn't force ESM on end users/developpers.

Using ESM in Typescript or older projects is not easy and will break things. It's just not worth it at this time.

As a side note: fetch is coming to node so there is really no hurry in breaking everything...

@lquixada
Copy link
Owner

@israelidanny as pointed out by @p-j , v3 has just been released and node-fetch is facing a lot of issues for being an ESM only lib (see link provided by him). I feel it would be prudent to monitor how that discussion unfolds before taking any actions.

@p-j re: your side note, unfortunately we can't firmly state that fetch is coming to node. Although the API has been merged intoundici, it's still unclear if undici itself will ever be merged into the node core. See discussion here: nodejs/node#38533.

@Lioness100
Copy link

Even if undici isnt't merged into node core, will we eventually replace node-fetch with it?

@lquixada
Copy link
Owner

@Lioness100 so far I don't see a good reason to replace node-fetch. We can keep a close eye on how undici develops though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants