Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing for v0.21.0 Release candidate & Final #42

Merged
merged 9 commits into from
Jan 15, 2021

Conversation

nolim1t
Copy link
Member

@nolim1t nolim1t commented Nov 27, 2020

Testing for v0.21.0 Release candidate

@nolim1t
Copy link
Member Author

nolim1t commented Nov 30, 2020

image

Seems to be working

Copy link
Collaborator

@AaronDewes AaronDewes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that a final v0.21.0 has been tagged, it'd be great to have a release soon. Is there still an issue with this code or has it just not been tested enough yet?

@nolim1t
Copy link
Member Author

nolim1t commented Jan 15, 2021

Now that a final v0.21.0 has been tagged, it'd be great to have a release soon. Is there still an issue with this code or has it just not been tested enough yet?

I've been running the release candidates fine on one of my nodes for a whole month (other than the V3 issue, its all good)

Thanks for the review @AaronDewes

@nolim1t
Copy link
Member Author

nolim1t commented Jan 15, 2021

I've switched it back to the official release and will merge if everything looks good

@nolim1t
Copy link
Member Author

nolim1t commented Jan 15, 2021

tagged and being built as we speak

@nolim1t nolim1t marked this pull request as ready for review January 15, 2021 03:02
@nolim1t nolim1t changed the title Testing for v0.21.0 Release candidate Testing for v0.21.0 Release candidate & Final Jan 15, 2021
@nolim1t
Copy link
Member Author

nolim1t commented Jan 15, 2021

Built - in testing now

Just some issues with the release scripts right now (DNS it seems)

@nolim1t
Copy link
Member Author

nolim1t commented Jan 15, 2021

I've also sent a Pull Request to umbrel

@nolim1t
Copy link
Member Author

nolim1t commented Jan 15, 2021

Documentation pertaining to v0.21.0 is all updated too. I've also addressed #46 regarding config stuff too.

Merging this in, and will address any other issues with blocking failed building (so far there is an issue uploading release assets due to some DNS error, which has nothing to do with the docker releases.

I would also like to add in another alternate docker hub too (GHCR and maybe gitlab too) in future so we are more resilient to decentralization

@nolim1t nolim1t merged commit 1f38c4a into lncm:master Jan 15, 2021
@nolim1t nolim1t deleted the v0.21-test branch January 15, 2021 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants