Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a small arabic dataset to mimesis giving it a push to start supporting arabic #1587

Closed
wants to merge 7 commits into from

Conversation

yah04dev
Copy link

@yah04dev yah04dev commented Sep 8, 2024

adding a small arabic dataset to mimesis giving it a push to start supporting arabic

I have made things!

Checklist

  • I have read contributing guidelines

  • I'm sure that I did not unrelated changes in this pull request

  • I have created at least one test case for the changes I have made

  • I have added myself to the CONTRIBUTORS.rst

  • I have updated the documentation for the changes I have made

  • I have added my changes to the CHANGELOG.rst

Related issues

I added a small arabic dataset but i was not able to make it working "Integrate it" because I am still a begginer, and i had a remark and an issue : arabic is an ltr language and utf8 , and I wanted to make an arabic adress format (state name <- street name <- house number) the data inerted but I wasnt able to make this format also arabic has multiple dailects and cultures ;I did my best to make the data look real I wish it will.

adding a small arabic dataset to mimesis giving it a push to start supporting arabic
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.38%. Comparing base (6807849) to head (ba44b38).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1587      +/-   ##
==========================================
+ Coverage   56.33%   56.38%   +0.04%     
==========================================
  Files          60       60              
  Lines        2178     2178              
==========================================
+ Hits         1227     1228       +1     
+ Misses        951      950       -1     

@lk-geimfari
Copy link
Owner

@yah04dev As-salamu alaykum. First of all, thank you for contributing to the Mimesis project. I believe that adding Arabic will be a great enhancement.

However, before we can merge your Pull Request, I have a few comments:

  1. Since Arabic is the official language in many countries, you need to explicitly specify for which country you are adding the data.
  2. You need to add a base dataset for the Arabic language that will be suitable for use across all Arabic-speaking countries.
  3. Additionally, you should create a dataset that inherits from the base one and extends it with data specific to the country for which you are adding the information.

You can find the list of language codes here: https://github.com/lk-geimfari/mimesis/tree/master/mimesis/datasets/locale_template

You can see an example of how this works with en, en-ca, and en-au.

@lk-geimfari
Copy link
Owner

@yah04dev Overall, you should review the link I sent above, because simply adding the data, unfortunately, is not enough.

@yah04dev
Copy link
Author

yah04dev commented Sep 9, 2024

@lk-geimfari Fruits , texts , quotes and some other data will stay the same because they are related to language and not culture ,So I will try to give at least one or two local-datasets , Thank you !

@yah04dev yah04dev closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants