feat: Passing objects #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-north
reviewed
Aug 4, 2018
| w, | ||
| l, | ||
| d, | ||
| dir |
There was a problem hiding this comment.
You're receiving dir as an argument here, but never make an assertion of how many times logger.dir() has been invoked. Just follow the same stuff you've set up for the other message counts below
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new feature: users can now pass in non-strings (e.g. objects, arrays, window etc).
Non string objects will be logged out in the console using
console.dirat the end, after all prefix and messages are logged with styling.Accompanying tests in logging-objects-test.ts file.