Skip to content
This repository has been archived by the owner on Jul 15, 2024. It is now read-only.

Rename Application to AppHandler #44

Open
PoignardAzur opened this issue Dec 7, 2022 · 4 comments · May be fixed by #176
Open

Rename Application to AppHandler #44

PoignardAzur opened this issue Dec 7, 2022 · 4 comments · May be fixed by #176

Comments

@PoignardAzur
Copy link
Contributor

Application is the global-equivalent of WindHandler it should be called AppHandler for a few reasons:

  • Consistency with WinHandler
  • Clearer name. To me, finding an "Application" in your code implies you've found the composition root of your app-specific state, when in fact you've found a lightweight handle to platform bindings.

I've bumped into this problem when writing Masonry, and I think @maan2003 bumped into it as well last year: https://xi.zulipchat.com/#narrow/stream/147926-druid/topic/Remove.20Application.3A.3Aglobal/near/238902785

@lord
Copy link
Collaborator

lord commented Mar 21, 2023

To add another bikeshed to the mix, when I write code, it's basically a 50/50 tossup whether I name the correct WinHandler or WindowHandle on the first try. Is there a reason to abbreviate one and not the other? And are these just the standard names in the world of windowing, or are there less-similar names that are also standard?

@nicoburns
Copy link

nicoburns commented Nov 23, 2023

are there less-similar names that are also standard?

Perhaps we could adopt macOS's Delegate for the Handler? I feel like the meaning of WindowHandle is pretty intuitive, but the meaning of WinHandler less so.

@xStrom
Copy link
Member

xStrom commented Nov 24, 2023

Simply renaming Application to AppHandler wouldn't work because there already is an AppHandler.

There has been some related discussion that isn't yet referenced in this specific thread. In writing we have #168 and the Removing WinHandler Zulip thread. The topic was also discussed during office hours but that is ephemeral, so no transcript.

Thus far the plan has shaped up to the following:

  • Rename Application to Glazier
  • Remove WinHandler and migrate its functionality to AppHandler
  • Potentially rename AppHandler to something better, but no consensus on that yet - more name proposals welcome!

@PoignardAzur
Copy link
Contributor Author

Remove WinHandler and migrate its functionality to AppHandler

Wait, isn't WinHandler a bridge for some stuff the platform sends you? Removing it sounds awkward.

@DJMcNab DJMcNab linked a pull request Dec 28, 2023 that will close this issue
13 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants