Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore build norace flag #761

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

dudong2
Copy link
Contributor

@dudong2 dudong2 commented Oct 26, 2022

Description

Restores the removeed build norace flag.
ref. #709

closes: #762

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@dudong2 dudong2 added the A: bug Something isn't working label Oct 26, 2022
@dudong2 dudong2 self-assigned this Oct 26, 2022
@@ -1,3 +1,6 @@
//go:build norace
// +build norace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to use this redundant constraint? Because go:build is enough after go 1.17.

Copy link
Contributor Author

@dudong2 dudong2 Oct 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know about that. However, when i save the code in the IDE, it automatically generates +build norace.

@zemyblue zemyblue added the C:x/foundation x/foundation module label Oct 27, 2022
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #761 (964ac7a) into main (1ebc973) will increase coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #761      +/-   ##
==========================================
+ Coverage   62.13%   62.20%   +0.07%     
==========================================
  Files         880      880              
  Lines       99479    99479              
==========================================
+ Hits        61807    61880      +73     
+ Misses      34071    33982      -89     
- Partials     3601     3617      +16     
Impacted Files Coverage Δ
x/collection/collection.go 78.57% <0.00%> (-1.79%) ⬇️
x/wasm/keeper/keeper.go 86.53% <0.00%> (+0.36%) ⬆️
x/collection/msgs.go 53.86% <0.00%> (+5.35%) ⬆️
x/token/msgs.go 52.47% <0.00%> (+6.08%) ⬆️
x/token/validation.go 98.18% <0.00%> (+32.72%) ⬆️
x/token/token.go 100.00% <0.00%> (+50.00%) ⬆️

@dudong2 dudong2 merged commit 720fc43 into Finschia:main Oct 27, 2022
@dudong2 dudong2 deleted the dudong2/fix/add-build-norace branch October 27, 2022 05:00
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build norace flag is removed from cli_test.go in x/foundation
3 participants