feat: add EventOwnerChanged and EventRootChanged #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #604 +/- ##
==========================================
+ Coverage 59.42% 59.46% +0.04%
==========================================
Files 814 814
Lines 95390 95408 +18
==========================================
+ Hits 56685 56735 +50
+ Misses 35168 35086 -82
- Partials 3537 3587 +50
|
zemyblue
reviewed
Jul 21, 2022
zemyblue
reviewed
Jul 22, 2022
| // EventOwnerChanged is emitted when the owner of token is changed by operation applied to its ancestor. | ||
| // | ||
| // Since: 0.46.0 (finschia) | ||
| message EventOwnerChanged { |
There was a problem hiding this comment.
Is there no changed owner information in this event?
There was a problem hiding this comment.
The address of the new owner was not included in the event on Daphne.
There was a problem hiding this comment.
If so, can I understand that it was not added for backwards compatibility?
There was a problem hiding this comment.
Adding a new field would not break the compatibility, but there is no reason to add it.
zemyblue
approved these changes
Jul 23, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
EventOwnerChangedandEventRootChanged.Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml