Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: publish docker image on tag push #469

Merged
merged 4 commits into from
Mar 18, 2022
Merged

ci: publish docker image on tag push #469

merged 4 commits into from
Mar 18, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Mar 17, 2022

It makes CI to publish the docker image on tag pushes.

Description

It adds a workflow which publishes the docker image on tag push event.
The destination is docker.io/line/lbm-simapp for now.
The image tag would be the corresponding semver and latest.

closes: #455

Motivation and context

Refer to #455

How has this been tested?

The PR will trigger the workflow. And I confirmed it works, I will revert the commit which triggers the workflow on PR.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes. [no need]
  • I have updated the documentation accordingly. [no need]
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml [no need]

@0Tech 0Tech added github_actions Pull requests that update Github_actions code A: CI labels Mar 17, 2022
@0Tech 0Tech self-assigned this Mar 17, 2022
@0Tech 0Tech changed the title ci: add docker image publish ci: publish docker image on tag push Mar 17, 2022
@0Tech
Copy link
Collaborator Author

0Tech commented Mar 17, 2022

I have confirmed it working.
You can check it at: https://hub.docker.com/r/line/lbm-simapp/tags
After the merge, it (pr-469) should be removed.

@0Tech 0Tech mentioned this pull request Mar 17, 2022
5 tasks
@0Tech 0Tech marked this pull request as ready for review March 17, 2022 07:57
@0Tech 0Tech requested review from dudong2 and zemyblue March 17, 2022 07:57
@zemyblue
Copy link
Member

Could you add the release version as a tag when merge a release PR?
I think it's better to push the docker image when the release note is wrote. Can an action do this?

@0Tech
Copy link
Collaborator Author

0Tech commented Mar 17, 2022

Could you add the release version as a tag when merge a release PR? I think it's better to push the docker image when the release note is wrote. Can an action do this?

I think it's possible, let me change the condition.

But I think it would be better to create "release" after we confirmed the docker image works. It means we should push the image before the "release".

Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: CI github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Register simapp docker image to docker hub
3 participants