Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mypy support #132

Closed
ZeeD opened this issue Aug 28, 2019 · 1 comment
Closed

add mypy support #132

ZeeD opened this issue Aug 28, 2019 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@ZeeD
Copy link
Contributor

ZeeD commented Aug 28, 2019

I see there are some type annotations sprinkled in the source.
I think would be useful to add the missing ones and add a PEP561-compatibile mark (adding the py.typed file in the package)

--
https://www.python.org/dev/peps/pep-0561/
@lidatong lidatong added the duplicate This issue or pull request already exists label Aug 31, 2019
@lidatong
Copy link
Owner

Hey, yep this is on the roadmap and is tracked in the parent issue #31 and raised in #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZeeD @lidatong