Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failures caused by nasm #1326

Open
x528491x opened this issue Sep 6, 2024 · 9 comments
Open

Build failures caused by nasm #1326

x528491x opened this issue Sep 6, 2024 · 9 comments
Labels

Comments

@x528491x
Copy link

x528491x commented Sep 6, 2024

Ever since the version bump for hyper-rustls, nasm becomes a dependency and it creates trouble while building.

Building with cargo build --release works, whereas when using cross, it does not work.

I see that you've also replaced cross with cargo in your build tests.

Would really like a fix for these build errors and the tagging of a new release as simply using the "latest" has become unpredictable

@x528491x x528491x added the bug label Sep 6, 2024
@x528491x
Copy link
Author

x528491x commented Sep 6, 2024

I just read #1318.

So will cross not work going forward and all cross builds have to be done only with cargo?

@roderickvd
Copy link
Member

@yubiuser

@x528491x
Copy link
Author

x528491x commented Sep 6, 2024

Issue reported upstream

aws/aws-lc-rs#514

@x528491x
Copy link
Author

x528491x commented Sep 6, 2024

Issue probably fixed upstream:

aws/aws-lc-rs#514 (comment)

@yubiuser
Copy link
Contributor

yubiuser commented Sep 6, 2024

The issue likely is with cross: it setups a docker container to actually do the build and it uses a fairly outdated base image (esp. if you use the tagged version and not installing from github directly). All dependencies that can't be downloaded as pre-build crates need to find their way into the image used. This can be quite a challenge (this is why I removed cross from librespot). But I see there might be some nasm pre-build crates soon....

@roderickvd
Copy link
Member

Fixed now?

@fivebanger
Copy link
Contributor

fivebanger commented Sep 20, 2024

Edit:
Moved to #1346

@yubiuser
Copy link
Contributor

@fivebanger

The error message indicates that your issue is not dircetly related to the issue reported by the OP (and you're not using cross). I would advice to open a new issue to not derail the thread.

@fivebanger
Copy link
Contributor

I have created a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants