Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Automatically go to video if the url is put into the search bar #6230

Closed
3 tasks done
amogusussy opened this issue Jul 14, 2024 · 6 comments · Fixed by #6300
Closed
3 tasks done
Labels
enhancement New feature or request

Comments

@amogusussy
Copy link

amogusussy commented Jul 14, 2024

Describe your suggested feature

You should be able to paste the url of any youtube video (youtu.be or youtube.com/watch) into the search bar, and then it automatically goes to that video.

When you press enter when searching, it should check if the text pasted matches a regex statement for a youtube url, and if it matches, then open that video.

Other details

This is a feature in NewPipe, if you want to see their implementation.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@amogusussy amogusussy added the enhancement New feature or request label Jul 14, 2024
@Bnyro
Copy link
Member

Bnyro commented Jul 14, 2024

That's not planned. Pasting the link already gives you the corrext video as result, and you already have the ability to share links directly with LibreTube or open them directly with the app.

@Bnyro Bnyro closed this as not planned Won't fix, can't repro, duplicate, stale Jul 14, 2024
@Bnyro Bnyro mentioned this issue Jul 18, 2024
3 tasks
@Bnyro
Copy link
Member

Bnyro commented Jul 18, 2024

Due to multiple requests about this, I'm reopening this issue.

@Bnyro Bnyro reopened this Jul 18, 2024
@akano12
Copy link
Collaborator

akano12 commented Jul 18, 2024

Due to multiple requests about this, I'm reopening this issue.

I sometimes get multiple results for same link, is this normal?

@Bnyro
Copy link
Member

Bnyro commented Jul 19, 2024

I sometimes get multiple results for same link, is this normal?

It's whatever YouTube returns to you when you paste the link in the search bar, LibreTube doesn't modify the link currently.

@amogusussy
Copy link
Author

Newpipe's implementation is in the extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeStreamLinkHandlerFactory.java file in the TeamNewPipe/NewPipeExtractor repository.
You can use this to base the feature on,

@Bnyro
Copy link
Member

Bnyro commented Jul 19, 2024

That's not necessary, we already have our own logic to detect and handle YouTube links, it's just used in other places of the app currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants