Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: redirect to the npm docs for latest release #541

Merged
merged 2 commits into from
Jan 29, 2020
Merged

docs: redirect to the npm docs for latest release #541

merged 2 commits into from
Jan 29, 2020

Conversation

shresthagrawal
Copy link
Contributor

Solves #540

@shresthagrawal shresthagrawal requested review from alanshaw and daviddias and removed request for alanshaw January 28, 2020 07:51
jacobheun
jacobheun suggested changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this is a helpful addition! I added a few suggestions / corrections.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@shresthagrawal @jacobheun
Apply suggestions from code review
08d8240 
Co-Authored-By: Jacob Heun <jacobheun@gmail.com>
@shresthagrawal
Copy link
Contributor Author

Thanks for the review @jacobheun, I have added the requested changes.

jacobheun
jacobheun approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jacobheun jacobheun merged commit ed0c2cb into libp2p:master Jan 29, 2020
@jacobheun jacobheun mentioned this pull request Jan 29, 2020
Closed
@shresthagrawal shresthagrawal deleted the docs/redirect branch January 29, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobheun jacobheun jacobheun approved these changes

@daviddias daviddias Awaiting requested review from daviddias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shresthagrawal @jacobheun