Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async await version of examples/chat #482

Merged
merged 10 commits into from
Nov 27, 2019
Merged

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Nov 25, 2019

Note: depends on

@dirkmc dirkmc changed the base branch from master to refactor/async-await November 25, 2019 21:54
@dirkmc dirkmc force-pushed the fix/examples-chat branch 2 times, most recently from 95f61e3 to 7ead9f8 Compare November 26, 2019 15:10
betamos and others added 9 commits November 26, 2019 16:54
Array.shift seems to be very slow, perhaps linear, on some
engines, resulting in  _update consuming a lot of CPU.
* docs(fix): correct docs and example for pnet

* docs(fix): correct pnet docs
`ipfs.files.cat` is incorrect. the correct function is `ipfs.cat`
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@jacobheun jacobheun merged commit e5f8cad into refactor/async-await Nov 27, 2019
@jacobheun jacobheun deleted the fix/examples-chat branch November 27, 2019 11:43
jacobheun pushed a commit that referenced this pull request Dec 12, 2019
* fix: performance bottleneck in stat.js (#463)

Array.shift seems to be very slow, perhaps linear, on some
engines, resulting in  _update consuming a lot of CPU.

* docs(fix): correct docs and example for pnet (#464)

* docs(fix): correct docs and example for pnet

* docs(fix): correct pnet docs

* docs(fix): update README.md language (#468)

* docs: reciprocate (#474)

* docs(example): fix ipfs cat (#475)

`ipfs.files.cat` is incorrect. the correct function is `ipfs.cat`

* fix: async-await example chat

* fix: move handler before start

* fix: examples readme typos (#481)

* fix: simplify libp2p bundle for echo example

* chore: remove unused vars
jacobheun pushed a commit that referenced this pull request Jan 24, 2020
* fix: performance bottleneck in stat.js (#463)

Array.shift seems to be very slow, perhaps linear, on some
engines, resulting in  _update consuming a lot of CPU.

* docs(fix): correct docs and example for pnet (#464)

* docs(fix): correct docs and example for pnet

* docs(fix): correct pnet docs

* docs(fix): update README.md language (#468)

* docs: reciprocate (#474)

* docs(example): fix ipfs cat (#475)

`ipfs.files.cat` is incorrect. the correct function is `ipfs.cat`

* fix: async-await example chat

* fix: move handler before start

* fix: examples readme typos (#481)

* fix: simplify libp2p bundle for echo example

* chore: remove unused vars
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
## [9.3.8](libp2p/js-libp2p-kad-dht@v9.3.7...v9.3.8) (2023-06-15)

### Dependencies

* bump multiformats from 11.0.2 to 12.0.1 ([libp2p#482](libp2p/js-libp2p-kad-dht#482)) ([945bc36](libp2p/js-libp2p-kad-dht@945bc36))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants