This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
fix: handle listen error #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `net.Server` `.listen` callback is not a node-style callback, it's a listener for the `listen` event. To handle `listen` errors, one must listen for the `error` event, so update the code to do that and add a test to prevent regressions.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 5, 2022
## [5.0.2](v5.0.1...v5.0.2) (2022-11-05) ### Bug Fixes * handle listen error ([#224](#224)) ([4125e9e](4125e9e))
|
🎉 This PR is included in version 5.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
net.Server.listencallback is not a node-style callback that gets passed an error, it's a listener for thelistenevent.To handle errors when
.listening, one must listen for theerrorevent, so update the code to do that and add a test to prevent regressions.