This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
fix: add socket keepalive #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with go-libp2p for [incoming](https://github.com/libp2p/go-libp2p/blob/master/p2p/transport/tcp/tcp.go#L85) and [outgoing](https://github.com/libp2p/go-libp2p/blob/master/p2p/transport/tcp/tcp.go#L191) connections
wemeetagain
reviewed
Aug 31, 2022
src/socket-to-conn.ts
Outdated
| } else { | ||
| const address = socket.address() | ||
|
|
||
| // @ts-expect-error type of address is `{} | AdressInfo` - how to exclude {}? |
There was a problem hiding this comment.
I think you can explicitly type address above.
const address: AddressInfo = ...
github-actions bot
pushed a commit
that referenced
this pull request
Sep 1, 2022
## [3.0.6](v3.0.5...v3.0.6) (2022-09-01) ### Bug Fixes * add socket keepalive ([#205](#205)) ([9ac799b](9ac799b)), closes [/github.com/libp2p/go-libp2p/blob/master/p2p/transport/tcp/tcp.go#L85](https://github.com/libp2p//github.com/libp2p/go-libp2p/blob/master/p2p/transport/tcp/tcp.go/issues/L85) [/github.com/libp2p/go-libp2p/blob/master/p2p/transport/tcp/tcp.go#L191](https://github.com/libp2p//github.com/libp2p/go-libp2p/blob/master/p2p/transport/tcp/tcp.go/issues/L191)
|
🎉 This PR is included in version 3.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistent with go-libp2p for incoming and outgoing connections