This repository has been archived by the owner on Aug 23, 2019. It is now read-only.
fix: dont compare empty strings #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jacobheun
requested review from
alanshaw and
vasco-santos
and removed request for
alanshaw
vasco-santos
approved these changes
Apr 11, 2019
|
So the address is actually coming from the observed addresses from identify. We're currently just blindly adding any of those to our address list. We should do some level of verification for this. I will add a note to look into this more as a part of libp2p/js-libp2p#202. I think it's a good place to validate we're doing the right thing with addresses. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is something in the libp2p system that ends up adding
/ipfs/{peerId}to our PeerInfo address list. This shouldn't be happening. While this doesn't solve that issue (I'm still determining where that's happening), it fixes an issue with transport address filtering. If any item in the list ofourAddrshappens to be an empty string, that will cause all the target peers addresses to get filtered out. This avoids that by filtering out empty strings fromourAddrs