This repository has been archived by the owner on Aug 23, 2019. It is now read-only.
fix: create separate events for connection tracking #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
dirkmc
suggested changes
Apr 10, 2019
Co-Authored-By: jacobheun <jacobheun@gmail.com>
dirkmc
approved these changes
Apr 10, 2019
jacobheun
added a commit
to libp2p/js-libp2p-connection-manager
that referenced
this pull request
Apr 10, 2019
BREAKING CHANGE: This migrates from using muxed events from libp2p to the new connection events introduced in libp2p/js-libp2p-switch#328. This enables the connection manager to have better information about the number of connections
vasco-santos
pushed a commit
to libp2p/js-libp2p-connection-manager
that referenced
this pull request
Apr 11, 2019
BREAKING CHANGE: This migrates from using muxed events from libp2p to the new connection events introduced in libp2p/js-libp2p-switch#328. This enables the connection manager to have better information about the number of connections
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
peer-mux-*events are currently used for both connection tracking and muxed connection tracking. This creates a problem for the Connection Manager because it won't be able to track unmuxed connections.The Connection Manager should be aware of all connections that are created and closed. This adds events for libp2p and subsequently the Connection Manager to hook into.