fix: dont compare empty strings (#330)

libp2p · Apr 11, 2019 · bb1a235 · bb1a235
1 parent 866e5a6
commit bb1a235
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/src/transport.js b/src/transport.js
@@ -236,6 +236,7 @@ function ourAddresses (peerInfo) {
         : `${addr}/ipfs/${ourPeerId}`
       return ourAddrs.concat([addr, otherAddr])
     }, [])
+    .filter(a => Boolean(a))
     .concat(`/ipfs/${ourPeerId}`)
 }
 

diff --git a/test/transport-manager.spec.js b/test/transport-manager.spec.js
@@ -95,6 +95,23 @@ describe('Transport Manager', () => {
       expect(dialableAddrs[0].toString()).to.equal('/ip6/::1/tcp/4001')
     })
 
+    it('should filter out our addrs that start with /ipfs/', () => {
+      const queryAddrs = [
+        '/ip4/127.0.0.1/tcp/4002/ipfs/QmebzNV1kSzLfaYpSZdShuiABNUxoKT1vJmCdxM2iWsM2j'
+      ].map(a => Multiaddr(a))
+
+      const ourAddrs = [
+        '/ipfs/QmSoLnSGccFuZQJzRadHn95W2CrSFmZuTdDWP8HXaHca9z'
+      ]
+
+      ourAddrs.forEach(a => peerInfo.multiaddrs.add(a))
+
+      const dialableAddrs = TransportManager.dialables(dialAllTransport, queryAddrs, peerInfo)
+
+      expect(dialableAddrs).to.have.length(1)
+      expect(dialableAddrs[0]).to.eql(queryAddrs[0])
+    })
+
     it('should filter our addresses over relay/rendezvous', () => {
       const peerId = peerInfo.id.toB58String()
       const queryAddrs = [