From 24f4661afc38dfc3597489b5689a195697ab59a9 Mon Sep 17 00:00:00 2001 From: Denys Zagorui Date: Thu, 7 Sep 2023 02:02:10 -0700 Subject: [PATCH] bpftool: Fix -Wcast-qual warning This cast was made by purpose for older libbpf where the bpf_object_skeleton field is void * instead of const void * to eliminate a warning (as i understand -Wincompatible-pointer-types-discards-qualifiers) but this cast introduces another warning (-Wcast-qual) for libbpf where data field is const void * It makes sense for bpftool to be in sync with libbpf from kernel sources Signed-off-by: Denys Zagorui Signed-off-by: Andrii Nakryiko Acked-by: Quentin Monnet Link: https://lore.kernel.org/bpf/20230907090210.968612-1-dzagorui@cisco.com --- src/gen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gen.c b/src/gen.c index 2883660d..04c47745 100644 --- a/src/gen.c +++ b/src/gen.c @@ -1209,7 +1209,7 @@ static int do_skeleton(int argc, char **argv) codegen("\ \n\ \n\ - s->data = (void *)%2$s__elf_bytes(&s->data_sz); \n\ + s->data = %2$s__elf_bytes(&s->data_sz); \n\ \n\ obj->skeleton = s; \n\ return 0; \n\