Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FileSize validator #365

Merged
merged 14 commits into from
Dec 10, 2020
Merged

Conversation

dalepotter
Copy link
Contributor

This work builds upon @mvi-x's code in #309 to add a FIleSize validator.

Refs #307

@codecov-io
Copy link

codecov-io commented Apr 11, 2019

Codecov Report

Merging #365 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
+ Coverage   99.67%   99.68%   +0.01%     
==========================================
  Files          18       18              
  Lines         911      941      +30     
  Branches       74       76       +2     
==========================================
+ Hits          908      938      +30     
  Misses          3        3
Impacted Files Coverage Δ
flask_wtf/file.py 100% <100%> (ø) ⬆️
tests/test_file.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b029c3...e2547d6. Read the comment docs.

Copy link

@avinash-bhosale avinash-bhosale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good all things

@pallets-eco pallets-eco deleted a comment from tvb Apr 6, 2020
@pallets-eco pallets-eco deleted a comment from andodet May 21, 2020
@dalepotter
Copy link
Contributor Author

Is anything else needed to enable this branch to be merged?

@azmeuk azmeuk merged commit 3908e66 into pallets-eco:master Dec 10, 2020
@dalepotter dalepotter deleted the 309-fix-review-comments branch December 10, 2020 15:02
@davidism davidism added this to the v0.15 milestone May 24, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

6 participants