Add to docs with example of validation errors in templates #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lepture
reviewed
Jan 9, 2018
docs/quickstart.rst
Outdated
| .. sourcecode:: html+jinja | ||
|
|
||
| {% if form.name.errors %} | ||
| <ul class=errors> |
There was a problem hiding this comment.
Use proper HTML instead.
<ul class="errors">
There was a problem hiding this comment.
I'm fine with either. Armin is adamant that we don't use quotes or closing tags if we don't have to in the Flask docs.
There was a problem hiding this comment.
Whoops, sorry for the typo. I've amended the commit and force-pushed, so it should be sorted now. Thanks
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 18 18
Lines 911 911
Branches 74 74
=======================================
Hits 908 908
Misses 3 3Continue to review full report at Codecov.
|
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to look at http://flask.pocoo.org/docs/0.12/patterns/wtforms/#forms-in-templates to see how to do this, and thought it would make a good addition to the Flask-WTF docs themselves.