Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect highlighting of dbgTraceIfShared #36

Open
david-christiansen opened this issue Apr 17, 2023 · 1 comment
Open

Incorrect highlighting of dbgTraceIfShared #36

david-christiansen opened this issue Apr 17, 2023 · 1 comment

Comments

@david-christiansen
Copy link

In this screenshot, the highlighting of dbgTraceIfShared is a bit funky:
image

It seems to me that the issue comes from here, where there is no word-end in the rx call, and that dbgTraceIfShared should be part of lean4-debugging as well.

Would a PR be welcome with this change?

Also, why do they call eval? It seems to me that eval on top of quote should just be ordinary code. Could that be removed in the same PR?
@Kha
Copy link
Contributor

Kha commented Apr 18, 2023 •
edited
Loading

Yes, PRs welcome! I only do very light reviewing of PRs here and mostly try not to think about this repo.

@casavaca casavaca mentioned this issue Mar 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kha @david-christiansen