Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign_update.dart crashes on Flutter 3.10.0 #49

Closed
umberto-sonnino opened this issue May 17, 2023 · 2 comments
Closed

sign_update.dart crashes on Flutter 3.10.0 #49

umberto-sonnino opened this issue May 17, 2023 · 2 comments

Comments

@umberto-sonnino
Copy link

I'm seeing a crash on the latest Flutter stable - the sign_update binary complains about not being able to modify the arguments list.

Unhandled exception:
Unsupported operation: Cannot add to a fixed-length list
#0      FixedLengthListMixin.add (dart:_internal/list.dart:21:5)
#1      main ([...]/auto_updater-0.1.6/bin/sign_update.dart:21:17)
#2      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:294:33)
#3      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:189:12)

A simple patch would be to clone the arguments list instead of adding to it, like so:

  final args = List<String>.from(arguments);

  if (Platform.isWindows) {
    if (args.length == 1) {
      args.add('.\\dsa_priv.pem');
    }
  }

  Process process = await Process.start(
    executable,
    args,
  );

I'd submit a PR but I don't think I have the privileges to push to this repository.

@annd22
Copy link

annd22 commented May 24, 2023

is there any update for this?

@lijy91
Copy link
Member

lijy91 commented May 27, 2023

Please update to 0.1.7

@lijy91 lijy91 closed this as completed May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants