Implement IDE suggestions for tests

leaderboardsgg · Sep 9, 2024 · 016c12f · 016c12f
1 parent 9296d24
commit 016c12f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 20 deletions.
diff --git a/LeaderboardBackend.Test/Categories.cs b/LeaderboardBackend.Test/Categories.cs
@@ -31,18 +31,15 @@ public async Task OneTimeSetUp()
     public void OneTimeTearDown() => _factory.Dispose();
 
     [Test]
-    public static void GetCategory_NotFound()
-    {
-        RequestFailureException e = Assert.ThrowsAsync<RequestFailureException>(
-            async () =>
-                await _apiClient.Get<CategoryViewModel>(
-                    $"/api/categories/69",
-                    new() { Jwt = _jwt }
-                )
-        )!;
-
-        Assert.AreEqual(HttpStatusCode.NotFound, e.Response.StatusCode);
-    }
+    public static async Task GetCategory_NotFound() =>
+        await _apiClient.Awaiting(
+            a => a.Get<CategoryViewModel>(
+                $"/api/cateogries/69",
+                new() { Jwt = _jwt }
+            )
+        ).Should()
+        .ThrowAsync<RequestFailureException>()
+        .Where(e => e.Response.StatusCode == HttpStatusCode.NotFound);
 
     [Test]
     public static async Task CreateCategory_GetCategory_OK()

diff --git a/LeaderboardBackend.Test/Runs.cs b/LeaderboardBackend.Test/Runs.cs
@@ -74,8 +74,8 @@ public static async Task CreateRun_OK()
 
             RunViewModel retrieved = await GetRun(created.Id);
 
-            Assert.NotNull(created);
-            Assert.AreEqual(created.Id, retrieved.Id);
+            created.Should().NotBeNull();
+            created.Id.Should().Be(retrieved.Id);
         }
 
         [Test]
@@ -88,13 +88,12 @@ public static async Task GetCategory_OK()
                 new() { Jwt = _jwt }
             );
 
-            Assert.NotNull(category);
-            Assert.AreEqual(category.Id, _categoryId);
+            category.Should().NotBeNull();
+            category.Id.Should().Be(_categoryId);
         }
 
-        private static async Task<RunViewModel> CreateRun()
-        {
-            return await _apiClient.Post<RunViewModel>(
+        private static async Task<RunViewModel> CreateRun() =>
+            await _apiClient.Post<RunViewModel>(
                 "/runs/create",
                 new()
                 {
@@ -108,7 +107,6 @@ private static async Task<RunViewModel> CreateRun()
                     Jwt = _jwt
                 }
             );
-        }
 
         private static async Task<RunViewModel> GetRun(Guid id) =>
             await _apiClient.Get<RunViewModel>(