From d04485baa5d780351e76c0d2966b4ae1e436c7f2 Mon Sep 17 00:00:00 2001
From: Claudia Richoux <c@laudiacay.cool>
Date: Wed, 11 Oct 2023 14:29:06 -0400
Subject: [PATCH] fixing tests

---
 .../src/ecc/curves/bn254_scalar_multiplication.rs      |  3 +--
 barustenberg/src/plonk/proof_system/proving_key.rs     |  1 -
 barustenberg/src/srs/tests.rs                          | 10 ++++------
 3 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/barustenberg/src/ecc/curves/bn254_scalar_multiplication.rs b/barustenberg/src/ecc/curves/bn254_scalar_multiplication.rs
index 804456b..1b50508 100644
--- a/barustenberg/src/ecc/curves/bn254_scalar_multiplication.rs
+++ b/barustenberg/src/ecc/curves/bn254_scalar_multiplication.rs
@@ -2,8 +2,7 @@ use ark_bn254::Fr;
 
 use ark_bn254::{G1Affine, G1Projective};
 use ark_ec::short_weierstrass::{Affine, SWCurveConfig};
-use ark_ec::AffineRepr;
-use ark_ff::{Field, Zero};
+use ark_ff::Zero;
 
 use crate::srs::io::read_transcript_g1;
 
diff --git a/barustenberg/src/plonk/proof_system/proving_key.rs b/barustenberg/src/plonk/proof_system/proving_key.rs
index 7bdd21c..7188a50 100644
--- a/barustenberg/src/plonk/proof_system/proving_key.rs
+++ b/barustenberg/src/plonk/proof_system/proving_key.rs
@@ -1,4 +1,3 @@
-use ark_bn254::G1Affine;
 use ark_ff::{FftField, Field};
 use serde::{Deserialize, Deserializer, Serialize, Serializer};
 use std::io::Read;
diff --git a/barustenberg/src/srs/tests.rs b/barustenberg/src/srs/tests.rs
index 90aab49..8dde867 100644
--- a/barustenberg/src/srs/tests.rs
+++ b/barustenberg/src/srs/tests.rs
@@ -1,8 +1,6 @@
 use ark_bn254::{Bn254, Fq12, G1Affine, G2Affine};
-use ark_ec::pairing::Pairing;
-use ark_ec::AffineRepr;
-use ark_ff::Field;
-use ark_ff::One;
+use ark_ec::{AffineRepr, pairing::Pairing};
+use ark_ff::{AdditiveGroup, One};
 
 use super::io;
 
@@ -24,7 +22,7 @@ fn read_transcript_loads_well_formed_srs() {
 
     assert_eq!(res, Fq12::one());
 
-    for i in 0..degree {
-        assert!(monomials[i].is_on_curve());
+    for mon in monomials.iter().take(degree) {
+        assert!(mon.is_on_curve());
     }
 }