Fix potential crash when parsing build logs #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When encountering an error in the log file, the server tries to associate a suitable range in the document using the line number. When the line number is completely wrong, a panic might occur if the line number does not exist.
|
@clason Maybe this changeset will fix the crash you are seeing here: #967 (comment) |
|
Yes, looks like it! Thank you! |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Dec 18, 2023
## [5.12.0] - 2023-12-03 ### Added - Infer `texlab.build.auxDirectory`, `texlab.build.logDirectory` and `texlab.build.pdfDirectory` from `latexmkrc` if available ([#907](latex-lsp/texlab#907)) ### Fixed - Do not report `undefined reference` errors when using `\nocite{*}` ([#964](latex-lsp/texlab#964)) - Fix potential crash when parsing build log files ([#973](latex-lsp/texlab#973)) - Set the final tab stop of the `\begin` snippet inside the environment ([#963](latex-lsp/texlab#963))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encountering an error in the build log file, the server tries to convert the line number into a (zero)-based offset. If the line number is (for some reason) completely wrong, a panic in the server can occur.