Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete cite= in acros \DeclareAcronym #324

Closed
obreitwi opened this issue Nov 19, 2020 · 3 comments
Closed

Complete cite= in acros \DeclareAcronym #324

obreitwi opened this issue Nov 19, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@obreitwi
Copy link

The acro package allows for a cite=-key to reference a citation to be printed when the acronym is first introduced.

It would be nice if texlab could perform the same expansion for cite=-keys as it does for "regular" citation-related commands.

I tried simply adding cite= as citation command in data/lang_data.json, but that seems to fail because texlab expects citationCommands to be commands and not entries in \DeclareAcronym.

Note: I am using texlab via coc-texlab

Any pointers would be appreciated. Thank you!

@pfoerster
Copy link
Member

Thanks for the report!

It would be nice if texlab could perform the same expansion for cite=-keys as it does for "regular" citation-related commands.

I tried simply adding cite= as citation command in data/lang_data.json, but that seems to fail because texlab expects citationCommands to be commands and not entries in \DeclareAcronym.

Yeah, the problem at the moment is that we do not currently parse key value pairs in command arguments and treat them like text instead. This needs to be fixed in order to implement this feature. As I said in #323, I am currently working on the LaTeX and BibTeX parsers, making them incremental, and I will add key value pair parsing for LaTeX as well. Once this is done, we can take a look at this issue. Just give me a little bit more time and I will get back to you. Thank you for contributing!

@pfoerster pfoerster added the enhancement New feature or request label Nov 21, 2020
@pfoerster
Copy link
Member

This feature has now shipped with texlab 3.x.

@obreitwi
Copy link
Author

obreitwi commented Jun 3, 2021

Thank you very much! Works like a charm <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants