Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with k8s.io/editdocs/ #6976

Closed
1 task
vishveshv opened this issue Jan 16, 2018 · 3 comments
Closed
1 task

Issue with k8s.io/editdocs/ #6976

vishveshv opened this issue Jan 16, 2018 · 3 comments
Assignees
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@vishveshv
Copy link

This is a correction request in kubernetes documentation

  • Feature Request
  • [ X] Bug Report

Kubernetes documentation on pull-image-private-registry should be updated as docker config has different json response than what is mentioned in document:

**Kubernetes imagePullSecret doesn't support new docker config i.e. it doesn't support config with {"auths":..} object. **

Page to Update:
https://kubernetes.io/editdocs/#docs/tasks/configure-pod-container/pull-image-private-registry.md

Client Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.0", GitCommit:"925c127ec6b946659ad0fd596fa959be43f0cc05", GitTreeState:"clean", BuildDate:"2017-12-15T21:07:38Z", GoVersion:"go1.9.2", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.0", GitCommit:"925c127ec6b946659ad0fd596fa959be43f0cc05", GitTreeState:"clean", BuildDate:"2017-12-15T20:55:30Z", GoVersion:"go1.9.2", Compiler:"gc", Platform:"linux/amd64"}

@zacharysarah zacharysarah added Needs Tech Review sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jan 26, 2018
@aburdenthehand
Copy link
Contributor

aburdenthehand commented Feb 6, 2018

Thanks for raising this @vishveshv.

It looks like there was a problem with the registry secret type and datakey in kubectl 1.9.0 (see kubernetes/kubernetes#57427 (comment) for more info and for workaround for 1.9.0), and fixed in 1.9.1. From what I can tell, the 'auths' element in the docs json representation is correct, however there are some other changes related to the 'regsecret' yaml example and the .dockercfg (now .dockerconfigjson) json output.

I've addressed these corrections in #7248
Hopefully that resolves the issue.

@aburdenthehand
Copy link
Contributor

#7248 has been merged.
I believe this issue can be closed.

@tengqm
Copy link
Contributor

tengqm commented Feb 14, 2018

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

No branches or pull requests

5 participants