Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster-API Security Self-Assessment Initiative #8

Closed
rficcaglia opened this issue Jun 3, 2021 · 17 comments · Fixed by #40
Closed

Cluster-API Security Self-Assessment Initiative #8

rficcaglia opened this issue Jun 3, 2021 · 17 comments · Fixed by #40
Assignees
Labels
sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/security Categorizes an issue or PR as relevant to SIG Security.

Comments

@rficcaglia
Copy link

This is to consolidate info and inform all the interested folks regarding discussions around security assessment of cluster-api sub-project.

This is our first attempt as a community where a Security SIG will perform a security assessment of a sub-project of a graduated CNCF project. So we expect to make slow but reasonable progress and will be open for feedback on how we can improve for the benefit of others who will follow us.

The first step of a (community driven) security assessment of a project is a self-assessment of the project. Although, this is typical done by the project maintainers, some of us in #sig-security would be happy to take a first crack at filling out the outline template provided by CNCF TAG-Security.

Currently the volunteers are educating themselves on cluster-api docs and presentations and will coordinate with maintainers (who understandably are very busy but are engaged).

Related items:

kubernetes/community#5792

cncf/tag-security#603

https://groups.google.com/g/kubernetes-sig-cluster-lifecycle/c/Fi0UGzfbQfY

@rficcaglia
Copy link
Author

rficcaglia commented Jun 3, 2021

EDIT: I guess I messed up the labels so re-commented below.

maybe we should/need to create a wg? @tabbysable @reylejano @PushkarJ ?

@k8s-ci-robot
Copy link
Contributor

@rficcaglia: The label(s) sig/sig-security, sig/cluster-api cannot be applied, because the repository doesn't have them.

In response to this:

/sig sig-security
/sig cluster-api

maybe we should/need to create a wg? @tabbysable @reylejano @PushkarJ ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rficcaglia
Copy link
Author

/sig security

@reylejano
Copy link
Member

Related issue in cluster-api repo kubernetes-sigs/cluster-api#4446

@neolit123
Copy link
Member

maybe we should/need to create a wg?

WGs have a contract with Kubernetes Steering and require a community page, Zoom call slots, Slack channels and yearly status reports. my vote would be to not create WGs for subproject security audits, but if people insist it can be done.

@PushkarJ
Copy link
Member

PushkarJ commented Jun 3, 2021

@rficcaglia regarding WG creation, our co-chair @tabbysable PoV is here, which I tend to agree with.

TL;DR this seems like a lower intensity effort that would not require a WG

@PushkarJ
Copy link
Member

PushkarJ commented Jun 3, 2021

/sig cluster-lifecycle

@tabbysable
Copy link
Member

For the record: this is wonderful, huge thanks to everyone involved.

@rficcaglia
Copy link
Author

here's my first pass at the self-assessment outline structure, ie not the CAPI details themselves but the high level parts to be filled in (including a place for someone to fill in the CAPI-specific features and controls). this is meant to be both for CAPI and serve as a template for future subproject use.

https://docs.google.com/document/d/1Fj_cLUN9kLruHbEgmYiEgoqZjf2rRuVOmQDGOKByaf4/edit?usp=sharing

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@PushkarJ
Copy link
Member

PushkarJ commented Oct 8, 2021

/remove-lifecycle stale
/transfer sig-security

@k8s-ci-robot k8s-ci-robot transferred this issue from kubernetes/community Oct 8, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2022
@PushkarJ
Copy link
Member

PushkarJ commented Jan 6, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2022
@PushkarJ
Copy link
Member

PushkarJ commented Jan 18, 2022

Just wanted to leave some updates here for folks who stumble upon this and are wondering what's the current status:

  • The group collaborates and meets regularly on sig-security-assess-capi
  • The scope is limited to Cluster API AWS provider focussing on two flows: workload control plane node creation and workload control plane node worker node creation
  • We conducted data flow diagram exercises across several different meetings in the past few months on these flows
  • The data flows along with identified threats are being discussed at the time of writing this update
  • We expect that the outcome of the discussion would be a list of Github issues that will enable us to address any identified threats in Cluster API

/assign @rficcaglia @PushkarJ
/sig cluster-lifecycle security

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/security Categorizes an issue or PR as relevant to SIG Security. labels Jan 18, 2022
@PushkarJ
Copy link
Member

/retitle Cluster-API Security Self-Assessment Initiative

@k8s-ci-robot k8s-ci-robot changed the title cluster-api security self assessment initiative Cluster-API Security Self-Assessment Initiative Feb 11, 2022
@PushkarJ
Copy link
Member

So far as a follow up on the security assessment, the following issues have been created:

@PushkarJ
Copy link
Member

Project tracker to manage completion of identified issues can be found here: https://github.com/orgs/kubernetes/projects/83/views/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/security Categorizes an issue or PR as relevant to SIG Security.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants