From 7034ebd23368c1661c63e67f5bfb092dbef08d4b Mon Sep 17 00:00:00 2001 From: Grant Rodgers Date: Fri, 24 Aug 2018 12:20:56 -0700 Subject: [PATCH] Add Delete options to fakeclient interface The fake client doesn't implement any of the options, so delete propagation won't actually work yet. --- pkg/client/fake/client.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/client/fake/client.go b/pkg/client/fake/client.go index d4051369d3..54f571633e 100644 --- a/pkg/client/fake/client.go +++ b/pkg/client/fake/client.go @@ -99,7 +99,7 @@ func (c *fakeClient) Create(ctx context.Context, obj runtime.Object) error { return c.tracker.Create(gvr, obj, accessor.GetNamespace()) } -func (c *fakeClient) Delete(ctx context.Context, obj runtime.Object) error { +func (c *fakeClient) Delete(ctx context.Context, obj runtime.Object, opts ...client.DeleteOptionFunc) error { gvr, err := getGVRFromObject(obj) if err != nil { return err @@ -108,6 +108,7 @@ func (c *fakeClient) Delete(ctx context.Context, obj runtime.Object) error { if err != nil { return err } + //TODO: implement propagation return c.tracker.Delete(gvr, accessor.GetNamespace(), accessor.GetName()) }