Controller runtime flag sync-period is not working as expected

[oliviassss]

Describe the bug
The controller runtime config flag --sync-period is not working as expected, the controller is not reconciling every 1hr as specified by default. Could be a bug.

Steps to reproduce

Expected outcome
A concise description of what you expected to happen.

Environment

• AWS Load Balancer controller version
• Kubernetes version
• Using EKS (yes/no), if so version?

Additional Context:

[oliviassss]

related issues:
#2800
#2515

[oliviassss]

The root cause of the issue with the controller not reconciling at the specified interval per --sync-period is due to the eventhandler ignoring the update event. The event handler currently checks for differences in annotation and spec between the old and new ingresses. If there is no difference, the update event is ignored to prevent unnecessary reconciliations that would result in AWS API calls. Therefore, reconciliation is not actually triggered in this situation.

We can utilize the Kubernetes resourceVersion as a fix instead. By checking if the resourceVersion is the same, we can skip the check for differences in annotation and spec between the old and new ingresses. We can incorporate this fix in our upcoming patch release.

Ref:

• https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/controllers/ingress/eventhandlers/ingress_events.go#L43
• https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/pkg/deploy/wafv2/web_acl_association_manager.go#L13

[oliviassss]

resolve as the fix has been shipped.