Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go mod breaks importing #231

Closed
avorima opened this issue Oct 28, 2019 · 5 comments · Fixed by #232
Closed

Go mod breaks importing #231

avorima opened this issue Oct 28, 2019 · 5 comments · Fixed by #232

Comments

@avorima
Copy link
Contributor

avorima commented Oct 28, 2019

Since Go 1.13 (I think) it is required that a v2 release or higher contain the major version in the module directive (https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher).

Since this is not set, it effectively breaks updating to v2.3.0:

go get github.com/kubernetes-csi/csi-test@v2.3.0
...
require github.com/kubernetes-csi/csi-test: version "v2.3.0" invalid: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v2

The solution is rather simple, but it may be a breaking change for some users.

@pohly
Copy link
Contributor

pohly commented Oct 28, 2019

Sounds like we should do a v3.0.0 and bump the import paths in the source code and in the go.mod file. Agreed?

We were discussing other breaking API changes. That would be a good time to do them.

@Ntr0
Copy link
Contributor

Ntr0 commented Oct 28, 2019

As I have just created a PR, I can easily update it to bump v3 ;)

@Ntr0
Copy link
Contributor

Ntr0 commented Oct 28, 2019

#232

@msau42
Copy link
Collaborator

msau42 commented Oct 28, 2019

@pohly right now our infra uses go1.12.1. should we update to 1.13 as well?

@pohly
Copy link
Contributor

pohly commented Oct 28, 2019

right now our infra uses go1.12.1. should we update to 1.13 as well?

We can, but it's unrelated to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants