GenLabels may select wrong Pods

[hougangliu]

#1064
kubeflow/pytorch-operator#204

Above PRs change GenLabels to common label, and I notice that 'DeprecatedLabelPyTorchJobName' and DeprecatedLabelTFJobName will be dropped, so after that, GenLabels will keep same keys in tf-operator and pytorch-operator, if a user create Tfjob and Pytorchjob with same name, the two operator will mismatch service and pod when sync up.

[issue-label-bot]

Issue-Label Bot is automatically applying the label kind/bug to this issue, with a confidence of 0.91. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[gaocegege]

Are you interested in fixing the issue? I think we could add a new label framework to avoid it.

[hougangliu]

yes, agree with you. what do you think add a label controller-name: jc.Controller.ControllerName()

[gaocegege]

SGTM. I think we can add it.

[johnugeorge]

Closing the issue as #1067 is merged
/close

[k8s-ci-robot]

@johnugeorge: Closing this issue.

In response to this:

Closing the issue as #1067 is merged
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.