From 6d689cbc68953c329f3c6afed8a3ba869c5d7882 Mon Sep 17 00:00:00 2001 From: Johnu George Date: Mon, 10 Jun 2019 08:11:06 +0530 Subject: [PATCH] Fix start timestamp (#170) --- pkg/controller.v1/pytorch/status.go | 4 ++-- pkg/controller.v1beta2/pytorch/status.go | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/controller.v1/pytorch/status.go b/pkg/controller.v1/pytorch/status.go index 2ddd32679..ebeeed19f 100644 --- a/pkg/controller.v1/pytorch/status.go +++ b/pkg/controller.v1/pytorch/status.go @@ -58,8 +58,8 @@ func (pc *PyTorchController) updateStatusSingle(job *pyv1.PyTorchJob, rtype pyv1 pylogger.LoggerForJob(job).Infof("PyTorchJob=%s, ReplicaType=%s expected=%d, running=%d, failed=%d", job.Name, rtype, expected, running, failed) - // All workers are running, set StartTime. - if running == replicas && job.Status.StartTime == nil { + // Set StartTime. + if job.Status.StartTime == nil { now := metav1.Now() job.Status.StartTime = &now // enqueue a sync to check if job past ActiveDeadlineSeconds diff --git a/pkg/controller.v1beta2/pytorch/status.go b/pkg/controller.v1beta2/pytorch/status.go index 2f211639a..578a06762 100644 --- a/pkg/controller.v1beta2/pytorch/status.go +++ b/pkg/controller.v1beta2/pytorch/status.go @@ -58,8 +58,8 @@ func (pc *PyTorchController) updateStatusSingle(job *v1beta2.PyTorchJob, rtype v pylogger.LoggerForJob(job).Infof("PyTorchJob=%s, ReplicaType=%s expected=%d, running=%d, failed=%d", job.Name, rtype, expected, running, failed) - // All workers are running, set StartTime. - if running == replicas && job.Status.StartTime == nil { + // Set StartTime. + if job.Status.StartTime == nil { now := metav1.Now() job.Status.StartTime = &now // enqueue a sync to check if job past ActiveDeadlineSeconds