Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the next review date of newly-created projects #43

Merged
merged 1 commit into from
Jun 3, 2023

Conversation

josh-berry
Copy link
Contributor

@josh-berry josh-berry commented May 29, 2023

Set the next review date of a newly-created project to days/weeks/months/years after today.

If we don't do this, the newly-created project will inherit the review date from the template, which is probably far in the past (i.e. whenever the template was created), and the newly-created project will immediately appear in the user's list of projects to review. This is probably not what the user wants, since they just created the project and will presumably review it after creation.

Testing:

  • Manually tested creation with all the project intervals (days, weeks, months, years)
  • Tested with weird/long intervals (e.g. confirmed that "10 days" gets added correctly)
  • Tested creation of action groups (to be sure the new logic doesn't introduce any crashes when it shouldn't be running)

Set the next review date of a newly-created project to <review interval>
days/weeks/months/years after today.

If we don't do this, the newly-created project will inherit the review
date from the template, which is probably far in the past (i.e. whenever
the template was created), and the newly-created project will
immediately appear in the user's list of projects to review.  This is
probably not what the user wants, since they just created the project
and will presumably review it after creation.

Signed-off-by: Joshua Berry <des@condordes.net>
@ksalzke
Copy link
Owner

ksalzke commented Jun 3, 2023

A sensible change. Thank you!

@ksalzke ksalzke merged commit 103ce55 into ksalzke:master Jun 3, 2023
@josh-berry
Copy link
Contributor Author

You're quite welcome! Thanks for making this plugin, it's super helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants