Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration bug #61

Closed
vikiival opened this issue May 1, 2022 · 10 comments · Fixed by #64
Closed

Migration bug #61

vikiival opened this issue May 1, 2022 · 10 comments · Fixed by #64
Assignees
@vikiival

Comments

@vikiival
Copy link
Member

vikiival commented May 1, 2022

e69bee8
@vikiival vikiival self-assigned this May 1, 2022
@vikiival
Copy link
Member Author

vikiival commented May 1, 2022

@KngZhi out of computer rn. Will fix later

@KngZhi
Copy link
Contributor

KngZhi commented May 3, 2022 •
edited
Loading

hi @vikiival, I run the current DB migration to test, and it caused an error that does not show highest_sale properly. It seems highest_sale column migration did not run successfully.

image

@KngZhi KngZhi mentioned this issue May 3, 2022
Merged
17 tasks
@vikiival
Copy link
Member Author

vikiival commented May 3, 2022

Looks like something is super fokked :)

@KngZhi
Copy link
Contributor

KngZhi commented May 3, 2022

😂

@vikiival vikiival linked a pull request May 3, 2022 that will close this issue
🐛 bad migration #64
Merged
@KngZhi
Copy link
Contributor

KngZhi commented May 3, 2022 •
edited
Loading

@vikiival it seems, db migrate should be ADD "highest_sale" rather than "highest_price", otherwise that column still does not exist, tested at local dev env.

@vikiival
Copy link
Member Author

vikiival commented May 3, 2022

:)

query MyQuery {
  series {
    highestSale
  }
}

migration should be oki

check by yourself

@KngZhi
Copy link
Contributor

KngZhi commented May 3, 2022 •
edited
Loading

nothing returned.

image

@KngZhi
Copy link
Contributor

KngZhi commented May 3, 2022

#66 I manually add this migration fix at local dev, run migration firstly, and do just process, I can see data locally right now.

@KngZhi
Copy link
Contributor

KngZhi commented May 3, 2022

hmmm, see data right now. Sorry to bother you.

image

@vikiival
Copy link
Member Author

vikiival commented May 4, 2022

hmmm, see data right now. Sorry to bother you.

No problemo :) ping me anytime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vikiival vikiival

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 bad migration kodadot/rubick
2 participants
@KngZhi @vikiival