Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access-Control-Allow-Origin set to '*' even when 'Origin' is supplied #94

Open
75lb opened this issue Jan 8, 2024 · 1 comment
Open
Labels

Comments

@75lb
Copy link

75lb commented Jan 8, 2024

The recent breaking change to fix this advisory fixes the scenario where an origin is not specified but it breaks the scenario where it is.

If an Origin is supplied in the request, the spec states the server "must return the origin for the specific client making the request" (i.e. the origin passed in). All my apps and test suites are configured to expect this behaviour, however this library now returns * instead.

Could you confirm that was the intended behaviour, to ignore the incoming request origin in all scenarios?

@75lb 75lb added the bug label Jan 8, 2024
@75lb 75lb changed the title 'Access-Control-Allow-Originfix' set to '*' even when 'Origin' is supplied Access-Control-Allow-Origin set to '*' even when 'Origin' is supplied Jan 8, 2024
@julienw
Copy link
Contributor

julienw commented Feb 1, 2024

The README mentions this case explicitely, so I think it was intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants