Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Apply a kind/proposal label for all Knative proposals #1476

Closed
RichieEscarez opened this issue Jun 17, 2019 · 4 comments
Closed
Assignees
Labels
kind/proposal Issues or PRs related to proposals.

Comments

@RichieEscarez
Copy link
Contributor

RichieEscarez commented Jun 17, 2019

For tracking and awareness across all Knative repos, can we update our process to require the kind/proposal label for any proposal created in any repo?

Using a label for all proposals could increase awareness and will allow simple tracking (you can view a list of all proposals on a single page):

https://github.com/search?q=org%3Aknative+label%3Akind%2Fproposal

Having a single reference point will reduce both the need to click through the multiple repo artifacts (WG meeting notes, individual repo issues, etc.), and the potential to miss a big change that's in the works.

It looks like knative/eventing is already using the label and I've just added that label to both the knative/docs and knative/website repos.

Can we get the other owners to create new kind/proposal labels and then apply them to any current and all future proposals?

Attn: Steering commitee and TOC:
cc/ @rgregg @evankanderson

@RichieEscarez RichieEscarez added the kind/proposal Issues or PRs related to proposals. label Jun 17, 2019
@evankanderson
Copy link
Member

What do you expect the semantics of kind/proposal to be? I'm not sure it's aligned right now. Which of the following would you expect to be tagged?

  • Major engineering re-architecture which doesn't have direct user impact?
  • Suggested process change around bug triage?
  • New feature on an existing custom resource?
  • New custom resource which is user-facing?
  • New custom resource which is inernal?
  • Enabling a field from corev1.Container which is currently validated out?
  • Testing plan for scalability testing of a component?

@evankanderson
Copy link
Member

Added to the June 20 TOC meeting

@RichieEscarez
Copy link
Contributor Author

Good question. The docs team is most concerned with "external facing changes" and I envision this as being one possible 'tool' for determining what might or is going into the V.next release.

If we were to narrow the scope of this down to just what the docs team would find most useful, I would expect the kind/proposal label on:

  • any external change that impacts users (of which might, or does require some form of communication or documentation).
  • [nice to have] notifications for new proposals that get added to that list

If others find this useful (for other use cases) then perhaps we can discuss options, like other qualifying labels or perhaps how to utilize prow (ie. dashboards with a "user-facing" section along side any other useful section(s)?).

For example, I didn't know that this Tekton Proposal existed (for one reason or another), and I think having a single point of reference to view potential "doc-impact-items" would be most efficient and effective (whether or not that's a query or something more in-depth (prow?)).

@RichieEscarez
Copy link
Contributor Author

Closing. Post TOC discussion. TODO: work with @eallred-google to define a formal process for flagging external facing change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/proposal Issues or PRs related to proposals.
Projects
None yet
Development

No branches or pull requests

4 participants