Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Need documentation on the need for sealing the lifecycle methods in MvvmComponentBase<T> #46

Closed
MarkStega opened this issue Jan 28, 2021 · 1 comment · Fixed by #50
Closed
Labels
type: feature New feature or enhancement

Comments

@MarkStega
Copy link

MarkStega commented Jan 28, 2021

MvvmComponentBase has accessible lifecycle methods. It certainly isn't clear why MvvmComponentBase[T] lifecycle methods are sealed preventing their override in a Blazor component that inherits from that class. I can see why one must call the base implementation of the methods since they are not simple virtuals. If they must remain sealed then documentation is needed as to why, and if they can be opened, then documentation on the need to call the base implementation is also needed.

@MarkStega MarkStega changed the title Need documentation on the need for sealing the lifecycle methods in MvvmComponentBaseT Need documentation on the need for sealing the lifecycle methods in MvvmComponentBase<T> Jan 28, 2021
@klemmchr
Copy link
Owner

Sorry for the late response. Actually there is no real reason why they are sealed. Probably I sealed them to prevent people from messing with them, but since it's common sense to call the base method, there is no real reason to have it like that. I'm going to unseal them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature New feature or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants