Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] convert all Option<String> params to Option<&str> #116

Open
omid opened this issue Apr 25, 2024 · 1 comment
Open

[Discussion] convert all Option<String> params to Option<&str> #116

omid opened this issue Apr 25, 2024 · 1 comment

Comments

@omid
Copy link
Contributor

omid commented Apr 25, 2024

Currently, all string params are Option<String> (57 occurrences).
What do you think of switching all with Option<&str>?

auth_client: Option<&str>, instead of auth_client: Option<String>,.

@kilork
Copy link
Owner

kilork commented Apr 25, 2024

I have not touched it as I wanted to keep API same as before, until OpenAPI will show it is stable. Actually seems like now nothing prevents us. Only precondition here is to not introduce breaking change, means it should wait for 25.x version of keycloak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants