Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(windows): remove cached context management from Keyman Engine #10052

Closed
10 tasks done
mcdurdin opened this issue Nov 22, 2023 · 0 comments · Fixed by #10065
Closed
10 tasks done

chore(windows): remove cached context management from Keyman Engine #10052

mcdurdin opened this issue Nov 22, 2023 · 0 comments · Fixed by #10065
Labels
chore windows/
Milestone
A17S27

Comments

@mcdurdin
Copy link
Member

mcdurdin commented Nov 22, 2023 •
edited
Loading

Part of #9999.

  • Remove AITIP::MergeContextWithCache
  • Remove AITIP::CopyContext, AITIP::RestoreContextOnly
  • Remove AITIP::QueueAction (see chore(windows): remove WM_KEYMANDEBUG_ messages #10050)
  • Remove AIWin2000Unicode::context
  • Where context->Reset() is used, instead tell core to reset km_core_state_context_clear
  • Move AppContext class to calldll.cpp, and remove from appint.h, and remove unused functionality (as AppContext still used by some of the calldll interactions)
  • Remove AIWin2000Unicode::QueueAction
  • Remove ContextItemsFromAppContext from appint
  • Update AppIntegration::ReadContext() to bool AppIntegration::ReadContext(WCHAR *buf)
  • In kmprocess.cpp, ReadContext update: if it returns TRUE, then we will km_core_state_context_set_if_needed
This was referenced Nov 23, 2023
Closed
Closed
Closed
Closed
@mcdurdin mcdurdin added this to the A17S26 milestone Nov 23, 2023
@rc-swag rc-swag mentioned this issue Nov 23, 2023
Merged
@darcywong00 darcywong00 modified the milestones: A17S26, A17S27 Nov 27, 2023
@mcdurdin mcdurdin mentioned this issue Dec 11, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore windows/
Projects
None yet
Milestone
A17S27
Development

Successfully merging a pull request may close this issue.

chore(windows): removed cached context windows engine keymanapp/keyman
2 participants
@mcdurdin @darcywong00