Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After Scrypt, run PBKDF2-HMAC-SHA512-SHA3 for a few iterations #26

Open
maxtaco opened this issue Nov 8, 2013 · 2 comments
Open

After Scrypt, run PBKDF2-HMAC-SHA512-SHA3 for a few iterations #26

maxtaco opened this issue Nov 8, 2013 · 2 comments
Assignees
@maxtaco

Comments

@maxtaco
Copy link
Contributor

maxtaco commented Nov 8, 2013

Right now, we're relying on PBKDF2-HMAC-SHA512-SHA3 as the final stage of key stretching, but that means we're vulnerable to a bug in SHA-512 leaving correlations among adjacent blocks (and thereby weakening the cipher cascade). I think the simple thing to do is a quick PBKDF2 with HMAC-SHA512 XOR HMAC-SHA3 as a finishing pass on the output of Scrypt.
@maxtaco
Copy link
Contributor Author

maxtaco commented Nov 8, 2013

Some progress, I implemented the KDF in keybase/python-triplesec@d8a1529

@ghost ghost assigned maxtaco Nov 8, 2013
@SparkDustJoe
Copy link

Is this still an issue with the switch to Argon2 in #51 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxtaco maxtaco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxtaco @SparkDustJoe