Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkinsRestorer | The issue where the items of mods that support curios mod do not appear after using the /skin set command #349

Open
3 of 6 tasks
TeQTabanca opened this issue Sep 4, 2024 · 7 comments
Labels
S-wontfix State: This will not be worked on T-bug Type: Something isn't working

Comments

@TeQTabanca
Copy link

TeQTabanca commented Sep 4, 2024

Basic questions:

  • I am actually using ketting, and not any other software (e.g. magma)
  • I am using the latest Ketting version at the time of writing for the Minecraft version, that I am using
  • I have provided full server logs and not a crash-report
  • I have checked all items without reading.
  • I have provided proper reproduction steps
  • I have ticked all boxes

What Minecraft Version is your Server on?

1.20.1

Full Ketting Version

1.20.1-47.3.6-0.3.25

Description of behavior

After using the /skin set command in the SkinsRestorer plugin, items from mods that support curios mod do not appear.

Curios API, SkinsRestorer, Tool Belt (I added Tool Belt mod because it works with Curios mod.)

Reproduction Steps

Steps to reproduce the behavior:
1. Install Curios API and Tool Belt mod.
2. Install the SkinsRestorer plugin.
3. Run the server and enter
4. /skin set <any player's name>

Logs

There are no errors in the server console

Additional context

My guess is that the SkinsRestorer plugin may not be seeing items similar to the Tool Belt mod when renewing the player's skin. That's why items may not appear. (I installed an alternative mod of the Curios API mod. Items continued to appear after using the /skin set command. So the problem seems to be in Curios API mod.)

Alternative Curios API mod: Accessories (Curios Compatibility Layer Required!)

@TeQTabanca TeQTabanca added the T-bug Type: Something isn't working label Sep 4, 2024
@p0t4t0sandwich
Copy link

p0t4t0sandwich commented Sep 4, 2024

Have you tried replicating the issue on an online server? (You should also provide logs regardless of whether you see errors, because there is always useful contextual info)

@TeQTabanca
Copy link
Author

Have you tried replicating the issue on an online server? (You should also provide logs regardless of whether you see errors, because there is always useful contextual info)

I'm already trying it on the server. It doesn't give any errors.

@TeQTabanca
Copy link
Author

TeQTabanca commented Sep 5, 2024

Have you tried replicating the issue on an online server? (You should also provide logs regardless of whether you see errors, because there is always useful contextual info)

When I equip or remove items from mods that support the Curios API mod, it gives an error in the console.

[20:16:37] [Server thread/ERROR] [or.bu.in.InventoryView/]: Slot 49 greater than inventory slot count

@C0D3-M4513R C0D3-M4513R added the S-wontfix State: This will not be worked on label Sep 9, 2024
@C0D3-M4513R
Copy link
Member

C0D3-M4513R commented Sep 9, 2024

Have you tried replicating the issue on an online server? (You should also provide logs regardless of whether you see errors, because there is always useful contextual info)

When I equip or remove items from mods that support the Curios API mod, it gives an error in the console.

[20:16:37] [Server thread/ERROR] [or.bu.in.InventoryView/]: Slot 49 greater than inventory slot count

If what I think what is happening is happpening (which is that SkinsRestorer effetively completely clears the inv and re-gives you the items later), then we can't fix this.

Also that is why we always ask for logs.

@TeQTabanca
Copy link
Author

TeQTabanca commented Sep 10, 2024

Have you tried replicating the issue on an online server? (You should also provide logs regardless of whether you see errors, because there is always useful contextual info)

When I equip or remove items from mods that support the Curios API mod, it gives an error in the console.

[20:16:37] [Server thread/ERROR] [or.bu.in.InventoryView/]: Slot 49 greater than inventory slot count

If what I think what is happening is happpening (which is that SkinsRestorer effetively completely clears the inv and re-gives you the items later), then we can't fix this.

Also that is why we always ask for logs.

The problem is that I only install and try the problematic mods on the test server and the text I sent you does not appear, but the problem still persists.

Logs (Skinrestorer plugin's debug mode is on!)

@TeQTabanca
Copy link
Author

I presented a mod similar to the curios API mod I mentioned above. When using that mod, wings, belts, etc. appear after typing the /skin set command. My guess is that the curios api cannot register the items connected to the curios api mod to the bukkit item api.

@C0D3-M4513R
Copy link
Member

My best guess is that curios just doesn't properly update the inventory size or uses a different internal inventory.

This is not looking like something we can fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-wontfix State: This will not be worked on T-bug Type: Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants