Added Debug Info for Line Ending Issues #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdangerw
reviewed
Mar 25, 2022
CONTRIBUTING.md
Outdated
| @@ -106,6 +106,10 @@ If after running these the CI flow is still failing, try updating `flake8`, | |||
| `isort` and `black`. This can be done by running `pip install --upgrade black`, | |||
| `pip install --upgrade flake8`, and `pip install --upgrade isort`. | |||
|
|
|||
| If you face issues while running the shell scripts and face errors like | |||
| `: invalid option` one possible reason might be that the line endings are | |||
There was a problem hiding this comment.
This looks good, but can you post the full error in a comment here or on this issue so we can take a look?
|
@mattdangerw I've updated the message as per our discussion |
|
Thanks! |
adhadse
pushed a commit
to adhadse/keras-nlp
that referenced
this pull request
Sep 17, 2022
* Added Debug Info for Line Ending Issues * Updated Debug Message * Define term WSL Co-authored-by: Matt Watson <1389937+mattdangerw@users.noreply.github.com>
mattdangerw
added a commit
that referenced
this pull request
May 21, 2024
mattdangerw
added a commit
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60
I've added a couple of sentences in the contributing file to help users debug the issue