Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for SparkHook needs updating to v19 #4118

Open
alexisdrakopoulos opened this issue Aug 26, 2024 · 2 comments
Open

Documentation for SparkHook needs updating to v19 #4118

alexisdrakopoulos opened this issue Aug 26, 2024 · 2 comments
Assignees
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation

Comments

@alexisdrakopoulos
Copy link

Description

The stable doc here: https://docs.kedro.org/en/stable/integrations/pyspark_integration.html is out of date I think.

Specifically:
parameters = context.config_loader.get("spark*", "spark*/**")

needs to be update to the new method.

I am mentioning this as I tried config_loader["spark"] with:

CONFIG_LOADER_ARGS = {
    "config_patterns": {
        "spark": ["spark*", "spark*/**"],
    },
}

but it couldn't find the conf/base/spark.yml for some reason, so I moved it to conf/databricks/spark.yml and now it finds it.

Documentation page (if applicable)

https://docs.kedro.org/en/stable/integrations/pyspark_integration.html

Context

@ElenaKhaustova
Copy link
Contributor

Thank you, @alexisdrakopoulos, for reporting an issue!

I tried to reproduce an issue, and I created conf/base/spark.yml and set

CONFIG_LOADER_ARGS = {
      "base_env": "base",
      "default_run_env": "local",
      "config_patterns": {
          "spark": ["spark*/"],
       }
}

and it seems to be working well; at least it can find conf/base/spark.yml
Screenshot 2024-08-27 at 12 05 25

So, for me, it looks like this line in the docs might not be relevant: parameters = context.config_loader.get("spark*", "spark*/**")

We will double-check and come back.

@merelcht
Copy link
Member

I'm bumping the priority on this, because it's been reported again in #4166

@merelcht merelcht added the Component: Documentation 📄 Issue/PR for markdown and API documentation label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation
Projects
Status: In Progress
Development

No branches or pull requests

5 participants
@alexisdrakopoulos @merelcht @lrcouto @ElenaKhaustova and others